netdev - Re: [PATCH net-next v2 12/12] selftests: drv-net: rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <915e5b8f-24c6-025e-97a3-3cd10a5018e1@gmail.com>
Date: Tue, 6 Aug 2024 17:48:27 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 dxu@...uu.xyz, przemyslaw.kitszel@...el.com, donald.hunter@...il.com,
 gal.pressman@...ux.dev, tariqt@...dia.com, willemdebruijn.kernel@...il.com,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v2 12/12] selftests: drv-net: rss_ctx: test
 dumping RSS contexts

On 03/08/2024 05:26, Jakub Kicinski wrote:
> Add a test for dumping RSS contexts. Make sure indir table
> and key are sane when contexts are created with various
> combination of inputs. Test the dump filtering by ifname
> and start-context.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
...
> +    expect_tuples = set([(cfg.ifname, -1)] + [(cfg.ifname, ctx_id) for ctx_id in ids])
> +
> +    # Dump all
> +    ctxs = cfg.ethnl.rss_get({}, dump=True)
> +    ctx_tuples = set([(c['header']['dev-name'], c.get('context', -1)) for c in ctxs])

Won't this return all ctxes on all netdevs in the system?

> +    ksft_eq(expect_tuples, ctx_tuples)

Whereas expect_tuples only contains cfg.ifname, so this
 assertion will fail if you have more than one RSS-
 supporting netdev.