netdev - Re: [PATCH v2 2/3] lib80211: Constify struct lib80211_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806085347.GP2636630@kernel.org>
Date: Tue, 6 Aug 2024 09:53:47 +0100
From: Simon Horman <horms@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: stas.yakovlev@...il.com, kvalo@...nel.org, gregkh@...uxfoundation.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, johannes@...solutions.net,
	linux-wireless@...r.kernel.org, linux-staging@...ts.linux.dev,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 2/3] lib80211: Constify struct lib80211_crypto_ops

On Mon, Aug 05, 2024 at 08:40:38AM +0200, Christophe JAILLET wrote:
> Now that functions in lib80211 handle "const struct lib80211_crypto_ops",
> some structure can be constified as well.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    7273	    604	     16	   7893	   1ed5	net/wireless/lib80211.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    7429	    444	     16	   7889	   1ed1	net/wireless/lib80211.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Simon Horman <horms@...nel.org>