lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <442332f001bf81a1cd8733d5c2ae94d344e5a286.camel@microchip.com>
Date: Wed, 7 Aug 2024 11:14:58 +0200
From: Steen Hegelund <steen.hegelund@...rochip.com>
To: Herve Codina <herve.codina@...tlin.com>, Geert Uytterhoeven
	<geert@...ux-m68k.org>, Andy Shevchenko <andy.shevchenko@...il.com>, "Simon
 Horman" <horms@...nel.org>, Lee Jones <lee@...nel.org>, Arnd Bergmann
	<arnd@...db.de>, Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
	<dragan.cvetic@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Philipp Zabel <p.zabel@...gutronix.de>,
	Lars Povlsen <lars.povlsen@...rochip.com>, Daniel Machon
	<daniel.machon@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Rob Herring
	<robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Horatiu Vultur <horatiu.vultur@...rochip.com>, "Andrew
 Lunn" <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>, "Allan
 Nielsen" <allan.nielsen@...rochip.com>, Luca Ceresoli
	<luca.ceresoli@...tlin.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Clément Léger <clement.leger@...tlin.com>
Subject: Re: [PATCH v4 5/8] reset: mchp: sparx5: Allow building as a module

Hi Herve,

On Mon, 2024-08-05 at 12:17 +0200, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Clément Léger <clement.leger@...tlin.com>
> 
> This reset controller can be used by the LAN966x PCI device.
> 
> The LAN966x PCI device driver can be built as a module and this reset
> controller driver has no reason to be a builtin driver in that case.
> 
> Signed-off-by: Clément Léger <clement.leger@...tlin.com>
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> ---
>  drivers/reset/Kconfig                  | 2 +-
>  drivers/reset/reset-microchip-sparx5.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 5b5a4d99616e..88350aa8a51c 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -133,7 +133,7 @@ config RESET_LPC18XX
>           This enables the reset controller driver for NXP
> LPC18xx/43xx SoCs.
> 
>  config RESET_MCHP_SPARX5
> -       bool "Microchip Sparx5 reset driver"
> +       tristate "Microchip Sparx5 reset driver"
>         depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI ||
> COMPILE_TEST
>         default y if SPARX5_SWITCH
>         select MFD_SYSCON
> diff --git a/drivers/reset/reset-microchip-sparx5.c
> b/drivers/reset/reset-microchip-sparx5.c
> index 636e85c388b0..69915c7b4941 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -158,6 +158,7 @@ static const struct of_device_id
> mchp_sparx5_reset_of_match[] = {
>         },
>         { }
>  };
> +MODULE_DEVICE_TABLE(of, mchp_sparx5_reset_of_match);
> 
>  static struct platform_driver mchp_sparx5_reset_driver = {
>         .probe = mchp_sparx5_reset_probe,
> @@ -180,3 +181,4 @@ postcore_initcall(mchp_sparx5_reset_init);
> 
>  MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver");
>  MODULE_AUTHOR("Steen Hegelund <steen.hegelund@...rochip.com>");
> +MODULE_LICENSE("GPL");
> --
> 2.45.0
> 

Looks good to me.

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ