netdev - Re: [PATCH iwl-next v2] ice: Implement ethtool reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <911af9ad-0b0d-4ac1-a2bc-da0dfc29b87e@intel.com>
Date: Wed, 7 Aug 2024 12:42:12 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Simon Horman <horms@...nel.org>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<anthony.l.nguyen@...el.com>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next v2] ice: Implement ethtool reset support



On 06.08.2024 16:55, Simon Horman wrote:
> On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote:
>> Enable ethtool reset support. Ethtool reset flags are mapped to the
>> E810 reset type:
>> PF reset:
>>   $ ethtool --reset <ethX> irq dma filter offload
>> CORE reset:
>>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>>     offload-shared ram-shared
>> GLOBAL reset:
>>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>>     offload-shared mac-shared phy-shared ram-shared
>>
>> Calling the same set of flags as in PF reset case on port representor
>> triggers VF reset.
>>
>> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
>> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
>> ---
>>  .../device_drivers/ethernet/intel/ice.rst     | 28 +++++++
>>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 77 +++++++++++++++++++
>>  2 files changed, 105 insertions(+)
>>
>> diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
>> index 934752f675ba..c043164bfacc 100644
>> --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst
>> +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
>> @@ -102,6 +102,34 @@ rx_bytes as "X", then ethtool (hardware statistics) will display rx_bytes as
>>  "X+40" (4 bytes CRC x 10 packets).
>>  
>>  
>> +ethtool reset
>> +-------------
>> +The driver supports 3 types of resets:
>> +- PF reset - resets only components associated with the given PF, does not
>> +  impact other PFs
>> +- CORE reset - whole adapter is affected, reset all PFs
>> +- GLOBAL reset - same as CORE but mac and phy components are also reinitialized
> 
> Hi Wojciech,
> 
> I'm not sure, but I think that Sphinx wants blank likes between these list
> items.

Thanks, I fixed that in v3

> 
> Flagged by make: htmldocs SPHINXDIRS=networking
> 
> ...
>