netdev - RE: [PATCH net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM4PR21MB35365A30785F40EA4E2B36F7CEB82@DM4PR21MB3536.namprd21.prod.outlook.com>
Date: Wed, 7 Aug 2024 15:25:53 +0000
From: Long Li <longli@...rosoft.com>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>, KY Srinivasan <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan
 Cui <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Shradha Gupta <shradhagupta@...ux.microsoft.com>, Simon
 Horman <horms@...nel.org>, Konstantin Taranov <kotaranov@...rosoft.com>,
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>, Erick Archer
	<erick.archer@...look.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH net] net: mana: Fix doorbell out of order violation and
 avoid unnecessary doorbell rings

> Subject: Re: [PATCH net] net: mana: Fix doorbell out of order violation and avoid
> unnecessary doorbell rings
> 
> 在 2024/8/6 7:38, longli@...uxonhyperv.com 写道:
> > From: Long Li <longli@...rosoft.com>
> >
> > After napi_complete_done() is called, another NAPI may be running on
> > another CPU and ring the doorbell before the current CPU does. When
> > combined with unnecessary rings when there is no need to ARM the CQ,
> > this triggers error paths in the hardware.
> >
> > Fix this by always ring the doorbell in sequence and avoid unnecessary
> > rings.
> 
> Trivial problem^_^
> 
> s/ring/ringing ?
> 
> Zhu Yanjun

I'm sending v2 to fix this.

Thanks,

Long