netdev - Re: [PATCH net-next 2/2] eth: fbnic: add support for basic qstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrOWgjPMeEGIjhuO@LQ3V64L9R2>
Date: Wed, 7 Aug 2024 16:45:06 +0100
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, alexanderduyck@...com,
	Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [PATCH net-next 2/2] eth: fbnic: add support for basic qstats

On Tue, Aug 06, 2024 at 07:26:31PM -0700, Jakub Kicinski wrote:
> From: Stanislav Fomichev <sdf@...ichev.me>
> 
> Implement netdev_stat_ops and export the basic per-queue stats.
> 
> This interface expect users to set the values that are used
> either to zero or to some other preserved value (they are 0xff by
> default). So here we export bytes/packets/drops from tx and rx_stats
> plus set some of the values that are exposed by queue stats
> to zero.
> 
>   $ cd tools/testing/selftests/drivers/net && ./stats.py
>   [...]
>   Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  .../net/ethernet/meta/fbnic/fbnic_netdev.c    | 67 +++++++++++++++++++
>  1 file changed, 67 insertions(+)

Reviewed-by: Joe Damato <jdamato@...tly.com>