netdev - Re: [PATCH v3 05/17] wifi: cc33xx: Add acx.c, acx.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e91645a1-aa5e-49bc-915b-f1bf9805ef51@ti.com>
Date: Wed, 7 Aug 2024 19:09:01 +0300
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC: Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH v3 05/17] wifi: cc33xx: Add acx.c, acx.h

On 8/7/2024 10:15 AM, Krzysztof Kozlowski wrote:
> On 06/08/2024 19:00, Michael Nemanov wrote:
>> These file contain various WLAN-oriented APIs
>>
>> Signed-off-by: Michael Nemanov <michael.nemanov@...com>
>> ---
>>   drivers/net/wireless/ti/cc33xx/acx.c | 1011 ++++++++++++++++++++++++++
>>   drivers/net/wireless/ti/cc33xx/acx.h |  835 +++++++++++++++++++++
>>   2 files changed, 1846 insertions(+)
>>   create mode 100644 drivers/net/wireless/ti/cc33xx/acx.c
>>   create mode 100644 drivers/net/wireless/ti/cc33xx/acx.h
>>
>> diff --git a/drivers/net/wireless/ti/cc33xx/acx.c b/drivers/net/wireless/ti/cc33xx/acx.c
>> new file mode 100644
>> index 000000000000..3c9b590e69b1
>> --- /dev/null
>> +++ b/drivers/net/wireless/ti/cc33xx/acx.c
>> @@ -0,0 +1,1011 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (C) 2022-2024 Texas Instruments Incorporated - https://www.ti.com/
>> + */
>> +
>> +#include "acx.h"
>> +
>> +int cc33xx_acx_clear_statistics(struct cc33xx *cc)
>> +{
>> +	struct acx_header *acx;
>> +	int ret = 0;
>> +
>> +	cc33xx_debug(DEBUG_ACX, "acx clear statistics");
> 
> So you just re-implemented tracing.
> 
> No, I asked to drop such silly entry/exit messages because you duplicate
> existing mechanisms in the kernel.
> 
> That's a no everywhere. Do not write such code. You can have useful
> debug statements when tracing or kprobes or whatever you want is not
> sufficient.
> 
> Best regards,
> Krzysztof
> 

OK, I misunderstood the previous exchange with you and Kalle Valo. I'll 
remove all entry / exit cc33xx_debug traces. Non-trivial ones are OK 
tough, right?

Thanks and regards,
Michael.