netdev - Re: [PATCH] net: ag71xx: use phylink_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N8t0vNxq_xTxZFkjYgbrUG6GWBTQJAdt7T+XqD9YEb73g@mail.gmail.com>
Date: Wed, 7 Aug 2024 13:02:57 -0700
From: Rosen Penev <rosenp@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] net: ag71xx: use phylink_mii_ioctl

On Wed, Aug 7, 2024 at 12:38 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Aug 07, 2024 at 11:58:46AM -0700, Rosen Penev wrote:
> > f1294617d2f38bd2b9f6cce516b0326858b61182 removed the custom function for
> > ndo_eth_ioctl and used the standard phy_do_ioctl which calls
> > phy_mii_ioctl. However since then, this driver was ported to phylink
> > where it makes more sense to call phylink_mii_ioctl.
> >
> > Bring back custom function that calls phylink_mii_ioctl.
> >
> > Fixes: 892e09153fa3 ("net: ag71xx: port to phylink")
>
> I don't think the fixes tag is justified. phy_do_ioctl() should work,
> although i agree your change is the better way to do this. So for me,
> this patch is an improvement, not a fix. Or have you seen a real
> problem?
I have not no. I've just looked at other phylink drivers that seems to
be using phylink_mii_ioctl.
>
> Please read:
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
>
> and mark this patch for net-next, without the Fixes tag.
Will do. As it would be for net-next, would it make sense to mark this
patch as v2?
>
>     Andrew
>
> ---
> pw-bot: cr