netdev - Re: [PATCH net-next] net: phylib: do not disable autoneg for fixed speeds >= 1G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408080419.a2PXcqh8-lkp@intel.com>
Date: Thu, 8 Aug 2024 04:36:00 +0800
From: kernel test robot <lkp@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phylib: do not disable autoneg for fixed
 speeds >= 1G

Hi Russell,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-phylib-do-not-disable-autoneg-for-fixed-speeds-1G/20240807-185909
base:   net-next/main
patch link:    https://lore.kernel.org/r/E1sbdxI-0024Eo-HE%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next] net: phylib: do not disable autoneg for fixed speeds >= 1G
config: i386-buildonly-randconfig-004-20240808 (https://download.01.org/0day-ci/archive/20240808/202408080419.a2PXcqh8-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408080419.a2PXcqh8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408080419.a2PXcqh8-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/phy/phy_device.c:2124:34: error: passing 'const unsigned long *' to parameter of type 'unsigned long *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    2124 |         adv = linkmode_adv_to_mii_adv_t(advert);
         |                                         ^~~~~~
   include/linux/mii.h:143:60: note: passing argument to parameter 'advertising' here
     143 | static inline u32 linkmode_adv_to_mii_adv_t(unsigned long *advertising)
         |                                                            ^
   drivers/net/phy/phy_device.c:2147:39: error: passing 'const unsigned long *' to parameter of type 'unsigned long *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    2147 |         adv = linkmode_adv_to_mii_ctrl1000_t(advert);
         |                                              ^~~~~~
   include/linux/mii.h:218:65: note: passing argument to parameter 'advertising' here
     218 | static inline u32 linkmode_adv_to_mii_ctrl1000_t(unsigned long *advertising)
         |                                                                 ^
>> drivers/net/phy/phy_device.c:2401:4: error: call to undeclared function 'linkmode_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2401 |                         linkmode_set(set->bit, fixed_advert);
         |                         ^
   3 errors generated.


vim +2124 drivers/net/phy/phy_device.c

  2107	
  2108	/**
  2109	 * genphy_config_advert - sanitize and advertise auto-negotiation parameters
  2110	 * @phydev: target phy_device struct
  2111	 * @advert: auto-negotiation parameters to advertise
  2112	 *
  2113	 * Description: Writes MII_ADVERTISE with the appropriate values,
  2114	 *   after sanitizing the values to make sure we only advertise
  2115	 *   what is supported.  Returns < 0 on error, 0 if the PHY's advertisement
  2116	 *   hasn't changed, and > 0 if it has changed.
  2117	 */
  2118	static int genphy_config_advert(struct phy_device *phydev,
  2119					const unsigned long *advert)
  2120	{
  2121		int err, bmsr, changed = 0;
  2122		u32 adv;
  2123	
> 2124		adv = linkmode_adv_to_mii_adv_t(advert);
  2125	
  2126		/* Setup standard advertisement */
  2127		err = phy_modify_changed(phydev, MII_ADVERTISE,
  2128					 ADVERTISE_ALL | ADVERTISE_100BASE4 |
  2129					 ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM,
  2130					 adv);
  2131		if (err < 0)
  2132			return err;
  2133		if (err > 0)
  2134			changed = 1;
  2135	
  2136		bmsr = phy_read(phydev, MII_BMSR);
  2137		if (bmsr < 0)
  2138			return bmsr;
  2139	
  2140		/* Per 802.3-2008, Section 22.2.4.2.16 Extended status all
  2141		 * 1000Mbits/sec capable PHYs shall have the BMSR_ESTATEN bit set to a
  2142		 * logical 1.
  2143		 */
  2144		if (!(bmsr & BMSR_ESTATEN))
  2145			return changed;
  2146	
  2147		adv = linkmode_adv_to_mii_ctrl1000_t(advert);
  2148	
  2149		err = phy_modify_changed(phydev, MII_CTRL1000,
  2150					 ADVERTISE_1000FULL | ADVERTISE_1000HALF,
  2151					 adv);
  2152		if (err < 0)
  2153			return err;
  2154		if (err > 0)
  2155			changed = 1;
  2156	
  2157		return changed;
  2158	}
  2159	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki