netdev - Re: [PATCH net-next] net: mvpp2: Increase size of queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHzn2R2HCBEGgOf-8530zUsamL4T2XRLFVB420TtcbVWSBJMKg@mail.gmail.com>
Date: Wed, 7 Aug 2024 23:12:24 +0200
From: Marcin Wojtas <marcin.s.wojtas@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: mvpp2: Increase size of queue_name buffer

wt., 6 sie 2024 o 13:28 Simon Horman <horms@...nel.org> napisał(a):
>
> Increase size of queue_name buffer from 30 to 31 to accommodate
> the largest string written to it. This avoids truncation in
> the possibly unlikely case where the string is name is the
> maximum size.
>
> Flagged by gcc-14:
>
>   .../mvpp2_main.c: In function 'mvpp2_probe':
>   .../mvpp2_main.c:7636:32: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
>    7636 |                  "stats-wq-%s%s", netdev_name(priv->port_list[0]->dev),
>         |                                ^
>   .../mvpp2_main.c:7635:9: note: 'snprintf' output between 10 and 31 bytes into a destination of size 30
>    7635 |         snprintf(priv->queue_name, sizeof(priv->queue_name),
>         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    7636 |                  "stats-wq-%s%s", netdev_name(priv->port_list[0]->dev),
>         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    7637 |                  priv->port_count > 1 ? "+" : "");
>         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics").
> I am not flagging this as a bug as I am not aware that it is one.
>
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> index e809f91c08fb..9e02e4367bec 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> @@ -1088,7 +1088,7 @@ struct mvpp2 {
>         unsigned int max_port_rxqs;
>
>         /* Workqueue to gather hardware statistics */
> -       char queue_name[30];
> +       char queue_name[31];
>         struct workqueue_struct *stats_queue;
>
>         /* Debugfs root entry */
>

Reviewed-by: Marcin Wojtas <marcin.s.wojtas@...il.com>

Thanks!