netdev - Re: [PATCH net-next v3 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ebe8136f9d088fc9968e5438af5640382c024ac.camel@microchip.com>
Date: Wed, 7 Aug 2024 03:41:21 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<linux@...linux.org.uk>, <conor+dt@...nel.org>, <Woojung.Huh@...rochip.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <f.fainelli@...il.com>,
	<kuba@...nel.org>, <vtpieter@...il.com>, <UNGLinuxDriver@...rochip.com>,
	<marex@...x.de>, <edumazet@...gle.com>, <pabeni@...hat.com>
CC: <pieter.van.trappen@...n.ch>, <devicetree@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 5/5] net: dsa: microchip: apply KSZ87xx family
 fixes wrt datasheet

Hi Pieter,

On Tue, 2024-08-06 at 15:25 +0200, vtpieter@...il.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> 
> The KSZ87xx switches have 32 entries and not 8. This fixes -ENOSPC
> errors from ksz8_add_sta_mac when configured as a bridge.
> 
> Add a new ksz87xx_dev_ops structure to be able to use the
> ksz_r_mib_stat64 pointer for this family; this corrects a wrong
> mib->counters cast to ksz88xx_stats_raw. This fixes iproute2
> statistics.
> 
> Signed-off-by: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> ---
>  
>  static void ksz9477_phylink_mac_link_up(struct phylink_config
> *config,
>                                         struct phy_device *phydev,
>                                         unsigned int mode,
> @@ -1262,12 +1297,12 @@ const struct ksz_chip_data ksz_switch_chips[]
> = {
>                 .dev_name = "KSZ8795",
>                 .num_vlans = 4096,
>                 .num_alus = 0,
> -               .num_statics = 8,
> +               .num_statics = 32,
>                 .cpu_ports = 0x10,      /* can be configured as cpu
> port */
>                 .port_cnt = 5,          /* total cpu and user ports
> */
>                 .num_tx_queues = 4,
>                 .num_ipms = 4,
> -               .ops = &ksz8_dev_ops,

Why don't we rename ksz8_dev_ops also like KSZ88x3_dev_ops or
KSZ88xx_dev_ops, since it is now used only by KSZ8863 and KSZ8873
switches.