netdev - Re: [PATCH net-next 06/11] net/mlx5e: Use extack in set ringparams callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3719e2e9-8254-4be6-9b19-0907860ff550@nvidia.com>
Date: Wed, 7 Aug 2024 09:22:55 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next 06/11] net/mlx5e: Use extack in set ringparams
 callback

On 07/08/2024 4:16, Jakub Kicinski wrote:
> On Tue, 6 Aug 2024 15:57:59 +0300 Tariq Toukan wrote:
>>  	if (param->rx_jumbo_pending) {
>> -		netdev_info(priv->netdev, "%s: rx_jumbo_pending not supported\n",
>> -			    __func__);
>> +		NL_SET_ERR_MSG_MOD(extack, "rx-jumbo not supported");
>>  		return -EINVAL;
>>  	}
>>  	if (param->rx_mini_pending) {
>> -		netdev_info(priv->netdev, "%s: rx_mini_pending not supported\n",
>> -			    __func__);
>> +		NL_SET_ERR_MSG_MOD(extack, "rx-mini not supported");
>>  		return -EINVAL;
>>  	}
> 
> This is dead code in the first place, mlx5 doesn't set associated max
> values so:
> 
> 	if (ringparam.rx_pending > max.rx_max_pending ||
> 	    ringparam.rx_mini_pending > max.rx_mini_max_pending ||
> 	    ringparam.rx_jumbo_pending > max.rx_jumbo_max_pending ||
> 	    ringparam.tx_pending > max.tx_max_pending)
> 		return -EINVAL;
> 
> in the core will reject any attempts at using these.

Good catch, thanks!