netdev - Re: [PATCH net-next v3 4/5] net: dsa: microchip: add WoL support for KSZ87xx family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHvy4Aoo6ej11vYMG2jwe8VO6ZmWbO49zBHOLYmHvxmr2nF3PQ@mail.gmail.com>
Date: Thu, 8 Aug 2024 11:37:33 +0200
From: Pieter <vtpieter@...il.com>
To: Arun.Ramadoss@...rochip.com
Cc: andrew@...n.ch, olteanv@...il.com, davem@...emloft.net, 
	linux@...linux.org.uk, conor+dt@...nel.org, Woojung.Huh@...rochip.com, 
	robh@...nel.org, krzk+dt@...nel.org, f.fainelli@...il.com, kuba@...nel.org, 
	UNGLinuxDriver@...rochip.com, marex@...x.de, edumazet@...gle.com, 
	pabeni@...hat.com, pieter.van.trappen@...n.ch, devicetree@...r.kernel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/5] net: dsa: microchip: add WoL support for
 KSZ87xx family

On Wed 7 Aug 2024 at 05:56, <Arun.Ramadoss@...rochip.com> wrote:
>
> Hi Pieter,
>
>
> >
> > +               if (ksz_is_ksz87xx(dev))
> > +                       ksz_write8(dev, KSZ8795_REG_INT_EN,
> > KSZ8795_INT_PME_MASK);
>
> nitpick:
> Do we need to rename register like KSZ87xx_REG_INT_EN since it is
> common to other switches as well?

Hi Arun, well it's all a bit confusing already I have to admit. There is a
filename ksz8795.c that contains code for ksz88x3 and ksz87xx devices.
Also the tag protocol is named DSA_TAG_PROTO_KSZ8795.

Now it seems from function prefixes and ksz_common.h `is_ksz8`
that in many places `ksz8795` should be replaced by `ksz8` instead.
I don't it's up to me to make this kind of decisions so I went along with
the existing naming convention as much as I could but indeed, this
specific register I will rename to KSZ87xx_REG_INT_EN.

Thanks, Pieter