netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH3PR11MB831321BCBA25371A571F172AEAB92@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Thu, 8 Aug 2024 02:18:21 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Drewek, Wojciech" <wojciech.drewek@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, Jesper Dangaard Brouer <hawk@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, John Fastabend <john.fastabend@...il.com>, "Alexei
 Starovoitov" <ast@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>, "Kubiak,
 Michal" <michal.kubiak@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Nambiar, Amritha" <amritha.nambiar@...el.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, Jakub Kicinski
	<kuba@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, "Nagraj, Shravan"
	<shravan.nagraj@...el.com>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings
 instead of bpf program when unconfiguring



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, July 24, 2024 10:19 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Drewek, Wojciech <wojciech.drewek@...el.com>; Fijalkowski, Maciej
><maciej.fijalkowski@...el.com>; Jesper Dangaard Brouer <hawk@...nel.org>;
>Daniel Borkmann <daniel@...earbox.net>; Zaremba, Larysa
><larysa.zaremba@...el.com>; netdev@...r.kernel.org; John Fastabend
><john.fastabend@...il.com>; Alexei Starovoitov <ast@...nel.org>; linux-
>kernel@...r.kernel.org; Eric Dumazet <edumazet@...gle.com>; Kubiak,
>Michal <michal.kubiak@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Nambiar, Amritha
><amritha.nambiar@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
>Jakub Kicinski <kuba@...nel.org>; bpf@...r.kernel.org; Paolo Abeni
><pabeni@...hat.com>; David S. Miller <davem@...emloft.net>; Karlsson,
>Magnus <magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings
>instead of bpf program when unconfiguring
>
>If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on VSI
>without applying new ring configuration. When unconfiguring the VSI, we can
>encounter the state in which there is an XDP program but no XDP rings to
>destroy or there will be XDP rings that need to be destroyed, but no XDP
>program to indicate their presence.
>
>When unconfiguring, rely on the presence of XDP rings rather then XDP
>program, as they better represent the current state that has to be destroyed.
>
>Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
>Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_lib.c  | 4 ++--
>drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--
>drivers/net/ethernet/intel/ice/ice_xsk.c  | 6 +++---
> 3 files changed, 7 insertions(+), 7 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)