netdev - Re: [PATCH nf v1] netfilter: nfnetlink: Initialise extack before use in ACKs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m25xsaq74k.fsf@gmail.com>
Date: Fri, 09 Aug 2024 12:15:55 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,  Jozsef Kadlecsik
 <kadlec@...filter.org>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  netfilter-devel@...r.kernel.org,
  netdev@...r.kernel.org,  donald.hunter@...hat.com
Subject: Re: [PATCH nf v1] netfilter: nfnetlink: Initialise extack before
 use in ACKs

Simon Horman <horms@...nel.org> writes:

> On Tue, Aug 06, 2024 at 04:43:24PM +0100, Donald Hunter wrote:
>> Add missing extack initialisation when ACKing BATCH_BEGIN and BATCH_END.
>> 
>> Fixes: bf2ac490d28c ("netfilter: nfnetlink: Handle ACK flags for batch messages")
>> Signed-off-by: Donald Hunter <donald.hunter@...il.com>
>
> Hi Donald,
>
> I see two other places that extack is used in nfnetlink_rcv_batch().
> Is it safe to leave them as-is?

There is a memset at the start of the main while loop that zeroes extack
for those two cases.