netdev - Re: [PATCH net-next v4 02/12] eth: mvpp2: implement new RSS context API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809145629.GA1951@kernel.org>
Date: Fri, 9 Aug 2024 15:56:29 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, michael.chan@...adcom.com, shuah@...nel.org,
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com,
	ahmed.zaki@...el.com, andrew@...n.ch, willemb@...gle.com,
	pavan.chebbi@...adcom.com, petrm@...dia.com, gal@...dia.com,
	jdamato@...tly.com, donald.hunter@...il.com,
	marcin.s.wojtas@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH net-next v4 02/12] eth: mvpp2: implement new RSS context
 API

On Thu, Aug 08, 2024 at 08:18:17PM -0700, Jakub Kicinski wrote:
> Implement the separate create/modify/delete ops for RSS.
> 
> No problems with IDs - even tho RSS tables are per device
> the driver already seems to allocate IDs linearly per port.
> There's a translation table from per-port context ID
> to device context ID.
> 
> mvpp2 doesn't have a key for the hash, it defaults to
> an empty/previous indir table.
> 
> Note that there is no key at all, so we don't have to be
> concerned with reporting the wrong one (which is addressed
> by a patch later in the series).
> 
> Compile-tested only.
> 
> Reviewed-by: Edward Cree <ecree.xilinx@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v4:
>  - adjust to meaning of max_context_id from net

Hi Jakub,

Should rxfh_max_num_contexts be used instead?

I'm seeing:

  CC [M]  .../mvpp2_main.o
.../mvpp2_main.c:5794:10: error: ‘const struct ethtool_ops’ has no member named ‘rxfh_max_context_id’; did you mean ‘rxfh_max_num_contexts’?
 5794 |         .rxfh_max_context_id    = MVPP22_N_RSS_TABLES,
      |          ^~~~~~~~~~~~~~~~~~~
      |          rxfh_max_num_contexts


Which seems to make sense in the context of:

- net: ethtool: fix off-by-one error in max RSS context IDs
  https://git.kernel.org/netdev/net-next/c/b54de55990b0

...