netdev - Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com>
Date: Thu, 8 Aug 2024 22:42:08 -0700
From: Daiwei Li <daiweili@...il.com>
To: vinicius.gomes@...el.com
Cc: anthony.l.nguyen@...el.com, davem@...emloft.net, edumazet@...gle.com, 
	intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com, 
	jesse.brandeburg@...el.com, kuba@...nel.org, kurt@...utronix.de, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com, 
	richardcochran@...il.com, sasha.neftin@...el.com
Subject: Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

Hi,

It appears this change breaks PTP on the 82580 controller, as ptp4l reports:

> timed out while polling for tx timestamp increasing tx_timestamp_timeout or
> increasing kworker priority may correct this issue, but a driver bug likely
> causes it

The 82580 controller has a hardware bug in which reading TSICR doesn't clear
it. See this thread
https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/ where the
bug was confirmed by an Intel employee. Any chance we could add back the ack
for 82580 specifically? Thanks!