netdev - Re: [PATCH net-next v2 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172316698916.2542023.14755989610157748245.robh@kernel.org>
Date: Thu, 08 Aug 2024 19:29:49 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Tristram.Ha@...rochip.com
Cc: "David S. Miller" <davem@...emloft.net>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Woojung Huh <woojung.huh@...rochip.com>, 
 Tristram Ha <tristram.ha@...rochip.com>, Andrew Lunn <andrew@...n.ch>, 
 netdev@...r.kernel.org, Marek Vasut <marex@...x.de>, 
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
 Vladimir Oltean <olteanv@...il.com>, UNGLinuxDriver@...rochip.com, 
 Florian Fainelli <f.fainelli@...il.com>, Conor Dooley <conor+dt@...nel.org>, 
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
 Paolo Abeni <pabeni@...hat.com>, Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: dsa: microchip: Add
 KSZ8895/KSZ8864 switch support

On Thu, 08 Aug 2024 17:43:09 -0700, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <tristram.ha@...rochip.com>
> 
> KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
> KSZ8863, so it shares some registers and functions in those switches.
> KSZ8895 has 5 ports and so is more similar to KSZ8795.
> 
> KSZ8864 is a 4-port version of KSZ8895.  The first port is removed
> while port 5 remains as a host port.
> 
> Signed-off-by: Tristram Ha <tristram.ha@...rochip.com>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:24:26: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809004310.239242-2-Tristram.Ha@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.