netdev - Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172324922165.2057557.834820350130126130.robh@kernel.org>
Date: Fri, 09 Aug 2024 18:20:21 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Tristram.Ha@...rochip.com
Cc: Eric Dumazet <edumazet@...gle.com>, linux-kernel@...r.kernel.org, 
 UNGLinuxDriver@...rochip.com, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, 
 Vladimir Oltean <olteanv@...il.com>, devicetree@...r.kernel.org, 
 Florian Fainelli <f.fainelli@...il.com>, 
 Woojung Huh <woojung.huh@...rochip.com>, Andrew Lunn <andrew@...n.ch>, 
 Jakub Kicinski <kuba@...nel.org>, Marek Vasut <marex@...x.de>, 
 Tristram Ha <tristram.ha@...rochip.com>, netdev@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add
 SGMII port support to KSZ9477 switch

On Fri, 09 Aug 2024 16:38:37 -0700, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <tristram.ha@...rochip.com>
> 
> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
> 
> SFP is typically used so the default is 1.  The driver can detect
> 10/100/1000 SFP and change the mode to 2.  For direct connect this mode
> has to be explicitly set to 0 as driver cannot detect that
> configuration.
> 
> Signed-off-by: Tristram Ha <tristram.ha@...rochip.com>
> ---
>  .../devicetree/bindings/net/dsa/microchip,ksz.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/microchip,ksz.example.dtb: switch@0: Unevaluated properties are not allowed ('sgmii-mode' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809233840.59953-2-Tristram.Ha@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.