netdev - Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrfiEGWNb48t9HZz@lizhi-Precision-Tower-5810>
Date: Sat, 10 Aug 2024 17:56:32 -0400
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Ioana Ciornei <ioana.ciornei@....com>,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed
 property phys

On Sat, Aug 10, 2024 at 01:46:25PM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2024 22:06, Frank Li wrote:
> > Add missed property phys, which indicate how connect to serdes phy.
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@...000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > index 6538e0ce90b28..25d657be6956f 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > @@ -38,6 +38,10 @@ properties:
> >
> >    managed: true
> >
> > +  phys:
> > +    description: A reference to the SerDes lane(s)
>
> This is not the same phy as phy-handle points to?

I go through source code and dts, it is not the same. phys connect to chip
internal serdas phys. phy-handle points to external ethernet phy, which is
connected by mdio bus generally.

Frank
>
> Best regards,
> Krzysztof
>