netdev - Re: [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a65b3654-e123-4521-b753-6308ecd87a5d@kernel.org>
Date: Sat, 10 Aug 2024 17:02:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Ioana Ciornei <ioana.ciornei@....com>,
 "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using
 unevaluatedProperties

On 10/08/2024 16:52, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it have
> allOf: $ref: ethernet-controller.yaml#.
> 
> Remove all properties, which already defined in ethernet-controller.yaml.
> 
> Fixed below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
>    fsl-mc@...000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Change from v1 to v2
> - Remove properties, which already defined in ethernet-controller.yaml
> ---
>  .../bindings/net/fsl,qoriq-mc-dpmac.yaml         | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> index a1b71b35319e7..0a91d839382d0 100644
> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> @@ -24,24 +24,10 @@ properties:
>      maxItems: 1
>      description: The DPMAC number
>  
> -  phy-handle: true
> -
> -  phy-connection-type: true
> -
> -  phy-mode: true
> -
> -  pcs-handle:
> -    maxItems: 1
> -    description:
> -      A reference to a node representing a PCS PHY device found on
> -      the internal MDIO bus.

pcs-handle must stay because you must limit number of items.

Best regards,
Krzysztof