netdev - Re: [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52f84b76-3849-4fc7-94a3-fbaf23ce99af@lunn.ch>
Date: Sat, 10 Aug 2024 19:22:00 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: kernel test robot <lkp@...el.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing
 support

On Sat, Aug 10, 2024 at 08:16:48AM +0200, Oleksij Rempel wrote:
> On Sat, Aug 10, 2024 at 03:57:35AM +0800, kernel test robot wrote:
> > Hi Oleksij,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on net-next/main]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/phy-Add-Open-Alliance-helpers-for-the-PHY-framework/20240809-172119
> > base:   net-next/main
> > patch link:    https://lore.kernel.org/r/20240809072440.3477125-3-o.rempel%40pengutronix.de
> > patch subject: [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing support
> > config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240810/202408100348.U6S1jP0z-lkp@intel.com/config)
> > compiler: m68k-linux-gcc (GCC) 14.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240810/202408100348.U6S1jP0z-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408100348.U6S1jP0z-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/net/phy/open_alliance_helpers.c: In function 'oa_1000bt1_get_ethtool_cable_result_code':
> > >> drivers/net/phy/open_alliance_helpers.c:34:25: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
> >       34 |         u8 tdr_status = FIELD_GET(OA_1000BT1_HDD_TDR_STATUS_MASK, reg_value);
> >          |                         ^~~~~~~~~
> 
> Huh.. why it builds on arm?

There has been a couple of reports like this recently. I suspect there
is a some architecture header pulling in the needed header, and m68k
does not.

You might want to compare drivers/net/phy/open_alliance_helpers.i for
arm and m68k.

    Andrew