netdev - RE: [PATCH ethtool-next 0/4] Add ability to flash modules' firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR12MB45166C24CE3A2DBB97EF355AD8842@DM6PR12MB4516.namprd12.prod.outlook.com>
Date: Sun, 11 Aug 2024 08:22:25 +0000
From: Danielle Ratson <danieller@...dia.com>
To: Michal Kubecek <mkubecek@...e.cz>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, mlxsw
	<mlxsw@...dia.com>
Subject: RE: [PATCH ethtool-next 0/4] Add ability to flash modules' firmware

> From: Michal Kubecek <mkubecek@...e.cz>
> Sent: Saturday, 10 August 2024 2:07
> To: Danielle Ratson <danieller@...dia.com>
> Cc: netdev@...r.kernel.org; mlxsw <mlxsw@...dia.com>
> Subject: Re: [PATCH ethtool-next 0/4] Add ability to flash modules' firmware
> 
> On Tue, Jul 16, 2024 at 04:11:08PM +0300, Danielle Ratson wrote:
> > CMIS compliant modules such as QSFP-DD might be running a firmware
> > that can be updated in a vendor-neutral way by exchanging messages
> > between the host and the module as described in section 7.2.2 of
> > revision
> > 4.0 of the CMIS standard.
> >
> > Add ability to flash transceiver modules' firmware over netlink.
> >
> > Example output:
> >
> >  # ethtool --flash-module-firmware eth0 file test.img
> >
> > Transceiver module firmware flashing started for device swp23
> > Transceiver module firmware flashing in progress for device swp23
> > Progress: 99%
> > Transceiver module firmware flashing completed for device swp23
> >
> > In addition, add some firmware and CDB messaging information to
> > ethtool's output for observability.
> >
> > Patchset overview:
> > Patches #1-#2: adds firmware info to ethtool's output.
> > Patch #3: updates headers.
> > Patch #4: adds ability to flash modules' firmware.
> 
> Hello,
> 
> this series seems to be based on slightly different version of the kernel
> counterpart than what was merged into mainline. One difference I noticed is
> that this series uses ETHTOOL_A_MODULE_FW_FLASH_PASS while kernel
> headers use ETHTOOL_A_MODULE_FW_FLASH_PASSWORD; but I'm not sure
> if it's the only difference.
> 
> Could you please check it and update what is needed?
> 
> Michal

Hi Michal,

Thank you for your feedback.

Ill fix it in a new version, there is no other difference between the versions that I could find.

Thanks,
Danielle