netdev - Re: [PATCH net-next 4/4] RDMA/rxe: Set queue pair cur_qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <60557472-62b2-4323-b952-cf81e5560c16@linux.dev>
Date: Sun, 11 Aug 2024 18:24:46 +0800
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: Leon Romanovsky <leon@...nel.org>
Cc: Liu Jian <liujian56@...wei.com>, linux-rdma@...r.kernel.org,
 linux-s390@...r.kernel.org, netdev@...r.kernel.org, jgg@...pe.ca,
 zyjzyj2000@...il.com, wenjia@...ux.ibm.com, jaka@...ux.ibm.com,
 alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com,
 guwen@...ux.alibaba.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next 4/4] RDMA/rxe: Set queue pair cur_qp_state when
 being queried


在 2024/8/11 18:22, Zhu Yanjun 写道:
>
>
> 在 2024/8/11 16:31, Leon Romanovsky 写道:
>> On Fri, Aug 09, 2024 at 07:06:34PM +0800, Zhu Yanjun wrote:
>>> 在 2024/8/9 16:31, Liu Jian 写道:
>>>> Same with commit e375b9c92985 ("RDMA/cxgb4: Set queue pair state when
>>>>    being queried"). The API for ib_query_qp requires the driver to set
>>>> cur_qp_state on return, add the missing set.
>>>>
>>> Add the following?
>>> Cc:stable@...r.kernel.org
>> There is no need to add stable tag for RXE driver. Distros are not
>> supporting this driver, which is used for development and not for
>> production.
>
> I do not mean that this driver is supported in Distros.
>
> I mean that QP cur_qp_state is not set when being queried in rxe. In 
> other rdma drivers, this is set.
>
> This should be a problem in RXE. So I suggest to add "CC: 
> stable@...r.kernel.org".
>
> As such, the stable branch will backport this commit to fix this 
> problem in RXE.
>

Sorry. My mistakes.

No need to add this "CC: stable@...r.kernel.org"

Zhu Yanjun


> Anyway, thanks a lot for your reporting and fixing this problem in RXE.
>
> Best Regards,
>
> Zhu Yanjun
>
>> Thanks
>>
>>>> Fixes: 8700e3e7c485 ("Soft RoCE driver")
>>>> Signed-off-by: Liu Jian<liujian56@...wei.com>
>>>> ---
>>>>    drivers/infiniband/sw/rxe/rxe_verbs.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
> -- 
> Best Regards,
> Yanjun.Zhu

-- 
Best Regards,
Yanjun.Zhu