netdev - Re: [PATCH v3 08/12] testing: net-drv: add basic shaper test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240811124053.GI1951@kernel.org>
Date: Sun, 11 Aug 2024 13:40:53 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	Jiri Pirko <jiri@...nulli.us>,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 08/12] testing: net-drv: add basic shaper test

On Thu, Aug 08, 2024 at 03:34:43PM +0100, Simon Horman wrote:
> On Thu, Aug 08, 2024 at 07:17:54AM -0700, Jakub Kicinski wrote:
> > On Thu, 8 Aug 2024 13:20:42 +0100 Simon Horman wrote:

...

> > > It may be a bit heavy handed, but my tested solution is to invoke a
> > > baseline rebuild if a Kconfig change is made. At the very last it does
> > > address the problem at hand. (In precisely the same way as manually setting
> > > FIRST_IN_SERIES=1.)
> > > 
> > > The patch implementing this for build_allmodconfig.sh which I tested is
> > > below. If we want to go ahead with this approach then I expect it is best
> > > to add it to other build tests too. But this seems to be a good point
> > > to report my findings, so here we are.
> > > 
> > > --- build_allmodconfig.sh.orig  2024-08-08 07:30:56.599372164 +0000
> > > +++ build_allmodconfig.sh       2024-08-08 09:58:22.692206313 +0000
> > > @@ -34,8 +34,10 @@
> > >  echo "Tree base:"
> > >  git log -1 --pretty='%h ("%s")' HEAD~
> > > 
> > > -if [ x$FIRST_IN_SERIES == x0 ]; then
> > > -    echo "Skip baseline build, not the first patch"
> > > +if [ x$FIRST_IN_SERIES == x0 ] && \
> > > +   ! git diff --name-only HEAD~ | grep -q -E "Kconfig$"
> > > +then
> > > +    echo "Skip baseline build, not the first patch and no Kconfig updates"
> > >  else
> > >      echo "Baseline building the tree"
> > 
> > Excellent idea, let's try it! Could you send a PR to NIPA?
> 
> Yes, can do.

For reference, the PR is here:
https://github.com/linux-netdev/nipa/pull/35