netdev - Re: [PATCH v2 net-next] net: dsa: microchip: ksz9477: split half-duplex monitoring function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51ca6e1e-b3db-4a05-9da9-1ff5493a53f1@lunn.ch>
Date: Sun, 11 Aug 2024 18:22:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@...oirfairelinux.com>
Cc: netdev@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk,
	woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
	kuba@...nel.org, Tristram.Ha@...rochip.com,
	Arun.Ramadoss@...rochip.com, horms@...nel.org
Subject: Re: [PATCH v2 net-next] net: dsa: microchip: ksz9477: split
 half-duplex monitoring function

> -	ret = ksz_pread8(dev, port, REG_PORT_STATUS_0, &status);
> +	/* Errata DS80000754 recommends monitoring potential faults in
> +	 * half-duplex mode. The switch might not be able to communicate anymore
> +	 * in these states. If you see this message, please read the
> +	 * errata-sheet for more information:
> +	 * https://ww1.microchip.com/downloads/aemDocuments/documents
> +	 * /UNG/ProductDocuments/Errata/KSZ9477S-Errata-DS80000754.pdf

The 80 character rule is not sacrosanct. We allow strings which will
appear in the log to be longer than 80 because they are hard to grep
for otherwise. The 80 character limit is really about keeping the
indentation level low, encouraging lots of small functions which do
one thing, and does it well. This is exactly what you are doing here,
taking a big function and splitting it up into smaller functions with
less indentation. I see a URL as something which should not be split
like this, it should be allowed to be longer than 80 characters,
because i want it to be easy to copy/paste into a web browser.

With that fixed, please add a Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew