netdev - Re: [PATCH net-next] net: octeon_ep_vf: use ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812124224.GA7679@kernel.org>
Date: Mon, 12 Aug 2024 13:42:24 +0100
From: Simon Horman <horms@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, vburru@...vell.com, sedara@...vell.com,
	srasheed@...vell.com, sburla@...vell.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: octeon_ep_vf: use ethtool_sprintf/puts

On Thu, Aug 08, 2024 at 09:47:27PM -0700, Rosen Penev wrote:
> Simplifies the function and avoids manual pointer manipulation.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Thanks,

The code changes look good to me and my local testing shows that it compiles.
So, from that point of view:

Reviewed-by: Simon Horman <horms@...nel.org>

But I do have a few points about process, which I hope you will
give due consideration:

1. It would be good if the patch description was a bit more verbose.
   And indicated how you found this problem (by inspection?)
   and how it was tested (compile tested only?).

   This helps set expectations for reviewers of this patch,
   both now and in the future.

2. You have posed a number of similar patches.
   To aid review it would be best to group these, say in batches of
   no more than 10.

   F.e. Point 1, above, doesn't just apply to this patch.

3. Please do review the Networking subsystem process document

   https://docs.kernel.org/process/maintainer-netdev.html

...