Message-Id: <172347513874.603162.8901170126444753598.robh@kernel.org>
Date: Mon, 12 Aug 2024 09:09:35 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Danila Tikhonov <danila@...xyga.com>
Cc: neil.armstrong@...aro.org, ulf.hansson@...aro.org, 
 linux-hardening@...r.kernel.org, dmitry.baryshkov@...aro.org, 
 linux-kernel@...r.kernel.org, kees@...nel.org, krzk+dt@...nel.org, 
 heiko.stuebner@...rry.de, devicetree@...r.kernel.org, 
 macromorgan@...mail.com, linux-pm@...r.kernel.org, viresh.kumar@...aro.org, 
 lpieralisi@...nel.org, quic_rjendra@...cinc.com, kuba@...nel.org, 
 linux-arm-msm@...r.kernel.org, pabeni@...hat.com, fekz115@...il.com, 
 linux@...nlining.org, andre.przywara@....com, conor+dt@...nel.org, 
 konradybcio@...nel.org, gpiccoli@...lia.com, andersson@...nel.org, 
 rafael@...nel.org, netdev@...r.kernel.org, rafal@...ecki.pl, 
 tony.luck@...el.com, davidwronek@...il.com, linus.walleij@...aro.org, 
 edumazet@...gle.com, davem@...emloft.net
Subject: Re: [PATCH v2 00/11] Add Nothing Phone (1) support


On Thu, 08 Aug 2024 21:40:14 +0300, Danila Tikhonov wrote:
> This series of patches adds support for the Nothing Phone (1), identified
> as nothing,spacewar. The Nothing Phone (1) is built on the Qualcomm
> Snapdragon 778G+ (SM7325-AE, also known as yupik).
> 
> SM7325 is identical to SC7280 just as SM7125 is identical to SC7180, so
> SM7325 devicetree imports SC7280 devicetree as a base.
> 
> All of these patches are essential for the integration of the Nothing
> Phone (1) into the kernel. The inclusion of SoC IDs is particularly
> important, as I encounter crash dumps if the device tree lacks msm and
> board id information.
> 
> Changes in v2:
> - Add Krzysztof's R-b tag (patches no. 1, 2, 10)
> - Add Dmitry's R-b tag (patches no. 3, 4, 8)
> - Document SM7325 as fallback to QCM6490 (patch no. 5)
> - Drop patch no. 6 from v1
> - Document PN553 NFC IC as fallback to nxp-nci-i2c (patch no. 6)
> - Add Krzysztof's A-b tag (patches no. 7, 9)
> - Switch nl.nothing.tech/nothing.tech in commit msg (patch no. 9)
> - Add fallback compatibility for NFC (patch no. 10)
> - Fix interrupt type for NFC (patch no. 10)
> Note: Rob's A-b tag (patch no. 5) was not added because the patch was
> fixed. Please look at it again.
> - Link to v1:
> https://lore.kernel.org/all/20240729201843.142918-1-danila@jiaxyga.com/
> 
> To: Rob Herring <robh@...nel.org>
> To: Krzysztof Kozlowski <krzk+dt@...nel.org>
> To: Conor Dooley <conor+dt@...nel.org>
> To: Bjorn Andersson <andersson@...nel.org>
> To: Konrad Dybcio <konradybcio@...nel.org>
> To: "David S. Miller" <davem@...emloft.net>
> To: Eric Dumazet <edumazet@...gle.com>
> To: Jakub Kicinski <kuba@...nel.org>
> To: Paolo Abeni <pabeni@...hat.com>
> To: "Rafael J. Wysocki" <rafael@...nel.org>
> To: Viresh Kumar <viresh.kumar@...aro.org>
> To: Kees Cook <kees@...nel.org>
> To: Tony Luck <tony.luck@...el.com>
> To: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
> To: Ulf Hansson <ulf.hansson@...aro.org>
> To: Andre Przywara <andre.przywara@....com>
> To: Rajendra Nayak <quic_rjendra@...cinc.com>
> To: David Wronek <davidwronek@...il.com>
> To: Neil Armstrong <neil.armstrong@...aro.org>
> To: Heiko Stuebner <heiko.stuebner@...rry.de>
> To: "Rafał Miłecki" <rafal@...ecki.pl>
> To: Chris Morgan <macromorgan@...mail.com>
> To: Linus Walleij <linus.walleij@...aro.org>
> To: Lorenzo Pieralisi <lpieralisi@...nel.org>
> To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> To: Eugene Lepshy <fekz115@...il.com>
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-arm-msm@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: linux-hardening@...r.kernel.org
> Cc: linux@...nlining.org
> Signed-off-by: Danila Tikhonov <danila@...xyga.com>
> 
> Danila Tikhonov (9):
>   dt-bindings: arm: qcom,ids: Add IDs for SM7325 family
>   soc: qcom: socinfo: Add Soc IDs for SM7325 family
>   cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist
>   soc: qcom: pd_mapper: Add SM7325 compatible
>   dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible
>   dt-bindings: nfc: nxp,nci: Document PN553 compatible
>   dt-bindings: arm: cpus: Add qcom kryo670 compatible
>   dt-bindings: vendor-prefixes: Add Nothing Technology Limited
>   dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1
> 
> Eugene Lepshy (2):
>   arm64: dts: qcom: Add SM7325 device tree
>   arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1
> 
>  .../devicetree/bindings/arm/cpus.yaml         |    1 +
>  .../devicetree/bindings/arm/qcom.yaml         |    6 +
>  .../devicetree/bindings/net/nfc/nxp,nci.yaml  |    1 +
>  .../bindings/soc/qcom/qcom,pmic-glink.yaml    |    5 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |    2 +
>  arch/arm64/boot/dts/qcom/Makefile             |    1 +
>  .../boot/dts/qcom/sm7325-nothing-spacewar.dts | 1263 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm7325.dtsi          |   17 +
>  drivers/cpufreq/cpufreq-dt-platdev.c          |    1 +
>  drivers/soc/qcom/qcom_pd_mapper.c             |    1 +
>  drivers/soc/qcom/socinfo.c                    |    2 +
>  include/dt-bindings/arm/qcom,ids.h            |    2 +
>  12 files changed, 1302 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
> 
> --
> 2.45.2
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sm7325-nothing-spacewar.dtb' for 20240808184048.63030-1-danila@...xyga.com:

arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: /: qcom,board-id: False schema does not allow [[65547, 0]]
	from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: /: qcom,msm-id: False schema does not allow [[475, 65536]]
	from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@...8000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4]] is too long
	from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@...8000: interrupt-names:0: 'msi' was expected
	from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@...8000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7'] is too long
	from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: usb@...8800: interrupt-names: ['pwr_event', 'hs_phy_irq', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: video-codec@...0000: iommus: [[68, 8576, 32]] is too short
	from schema $id: http://devicetree.org/schemas/media/qcom,sc7280-venus.yaml#

Powered by blists - more mailing lists