netdev - Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zro9PhW7SmveJ2mv@nanopsycho.orion>
Date: Mon, 12 Aug 2024 18:50:06 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>,
	Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Simon Horman <horms@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

Mon, Aug 12, 2024 at 05:25:44PM CEST, kuba@...nel.org wrote:
>On Mon, 12 Aug 2024 16:58:33 +0200 Paolo Abeni wrote:
>> > It's a tree, so perhaps just stick with tree terminology, everyone is
>> > used to that. Makes sense? One way or another, this needs to be
>> > properly described in docs, all terminology. That would make things more
>> > clear, I believe.  
>> 
>> @Jakub, would you be ok with:
>> 
>> 'inputs' ->  'leaves'
>> 'output' -> 'node'
>> ?
>
>I think the confusion is primarily about the parent / child.
>input and output should be very clear, IMO.

For me, "inputs" and "output" in this context sounds very odd. It should
be children and parent, isn't it. Confused...


>
>> Also while at it, I think renaming the 'group()' operation as 
>> 'node_set()' could be clearer (or at least less unclear), WDYT?
>
>No idea how we arrived at node_set(), and how it can possibly 

subtree_set() ?


>represent a grouping operation.
>The operations is grouping inputs and creating a scheduler node.
>
>> Note: I think it's would be more user-friendly to keep a single 
>> delete/get/dump operation for 'nodes' and leaves.
>
>Are you implying that nodes and leaves are different types of objects?
>Aren't leaves nodes without any inputs?

Agree. Same op would be nice for both.