netdev - Re: [PATCH net-next v3 2/2] gve: Add RSS adminq commands and ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrs5SspHV06zP4cK@test-OptiPlex-Tower-Plus-7010>
Date: Tue, 13 Aug 2024 16:15:30 +0530
From: Hariprasad Kelam <hkelam@...vell.com>
To: Praveen Kaligineedi <pkaligineedi@...gle.com>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <willemb@...gle.com>,
        <jeroendb@...gle.com>, <shailend@...gle.com>, <hramamurthy@...gle.com>,
        <jfraker@...gle.com>, Ziwei Xiao <ziweixiao@...gle.com>
Subject: Re: [PATCH net-next v3 2/2] gve: Add RSS adminq commands and ethtool
 support

On 2024-08-13 at 03:50:13, Praveen Kaligineedi (pkaligineedi@...gle.com) wrote:
> From: Jeroen de Borst <jeroendb@...gle.com>
> 
> Introduce adminq commands to configure and retrieve RSS settings from
> the device. Implement corresponding ethtool ops for user-level
> management.
> 
> Signed-off-by: Jeroen de Borst <jeroendb@...gle.com>
> Co-developed-by: Ziwei Xiao <ziweixiao@...gle.com>
> Signed-off-by: Ziwei Xiao <ziweixiao@...gle.com>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> ---
> Changes in v2:
> 	- Update the GVE's get/set_rxfh functions to send the
> 	  ethtool_rxfh_param directly to related adminq functions so
> 	  that it can avoid the extra copy between ethtool and the
> 	  local gve_rss_config struct(Jakub Kicinski)
> 	- Remove the struct gve_rss_config that becomes unused
> 	- Add a comment in the gve_adminq_configure_rss function to
> 	  describe the device expections for the configure_rss adminq
> 	  command
> 
>  drivers/net/ethernet/google/gve/gve.h         |   2 +
>  drivers/net/ethernet/google/gve/gve_adminq.c  | 146 ++++++++++++++++++
>  drivers/net/ethernet/google/gve/gve_adminq.h  |  44 ++++++
>  drivers/net/ethernet/google/gve/gve_ethtool.c |  44 +++++-
>  4 files changed, 235 insertions(+), 1 deletion(-)
>
Reviewed-by: Hariprasad Kelam <hkelam@...vell.com>