netdev - Re: [PATCH net-next v13 00/14] Replace page_frag with page_frag_cache for sk_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aba9fae-563d-4a4e-8336-44e24551d9f9@huawei.com>
Date: Tue, 13 Aug 2024 19:30:05 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>, Alexander
 Duyck <alexander.duyck@...il.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Alexei
 Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper
 Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, <bpf@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next v13 00/14] Replace page_frag with page_frag_cache
 for sk_page_frag()

On 2024/8/8 20:37, Yunsheng Lin wrote:

...

> 
> CC: Alexander Duyck <alexander.duyck@...il.com>
> 
> 1. https://lore.kernel.org/all/20240228093013.8263-1-linyunsheng@huawei.com/
> 
> Change log:
> V13:
>    1. Move page_frag_test from mm/ to tools/testing/selftest/mm
>    2. Use ptr_ring to replace ptr_pool for page_frag_test.c
>    3. Retest based on the new testing ko, which shows a big different
>       result than using ptr_pool.

Hi, Davem & Jakub & Paolo
    It seems the state of this patchset is changed to 'Deferred' in the
patchwork, as the info regarding the state in 'Documentation/process/
maintainer-netdev.rst':

Deferred           patch needs to be reposted later, usually due to dependency
                   or because it was posted for a closed tree

Obviously it was not the a closed tree reason here, I guess it was the dependency
reason casuing the 'Deferred' here? I am not sure if I understand what sort of
dependency this patchset is running into? It would be good to mention what need
to be done avoid the kind of dependency too.


Hi, Alexander
    The v13 mainly address your comments about the page_fage_test module.
It seems the your main comment about this patchset is about the new API
naming now, and it seems there was no feedback in previous version for
about a week:

https://lore.kernel.org/all/ca6be29e-ab53-4673-9624-90d41616a154@huawei.com/

If there is still disagreement about the new API naming or other things, it
would be good to continue the discussion, so that we can have better
understanding of each other's main concern and better idea might come up too,
like the discussion about new layout for 'struct page_frag_cache' and the
new refactoring in patch 8.

>