netdev - Re: [PATCH v1 net] net: macb: Use rcu_dereference() for idev->ifa_list in macb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812184021.4a7abc18@kernel.org>
Date: Mon, 12 Aug 2024 18:40:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Vineeth
 Karumanchi <vineeth.karumanchi@....com>, Kuniyuki Iwashima
 <kuni1840@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net] net: macb: Use rcu_dereference() for
 idev->ifa_list in macb_suspend().

On Wed, 7 Aug 2024 21:00:21 -0700 Kuniyuki Iwashima wrote:
> In macb_suspend(), idev->ifa_list is fetched with rcu_access_pointer()
> and later the pointer is dereferenced as ifa->ifa_local.
> 
> So, idev->ifa_list must be fetched with rcu_dereference().

I don't see where this driver takes rcu_read_lock, but
__in_dev_get_rcu() will already splat so we're not making 
it any worse.