netdev - Re: [PATCH net-next v3 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dfa7ffb-f40b-452c-9c3e-6bb500e1a46a@redhat.com>
Date: Tue, 13 Aug 2024 15:54:22 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Tristram.Ha@...rochip.com, Woojung Huh <woojung.huh@...rochip.com>,
 UNGLinuxDriver@...rochip.com, devicetree@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <olteanv@...il.com>, Rob Herring <robh@...nel.org>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Marek Vasut <marex@...x.de>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864
 switch support

On 8/9/24 23:21, Tristram.Ha@...rochip.com wrote:
> @@ -542,11 +545,11 @@ static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr,
>   			shifts[STATIC_MAC_FWD_PORTS];
>   	alu->is_override = (data_hi & masks[STATIC_MAC_TABLE_OVERRIDE]) ? 1 : 0;
>   
> -	/* KSZ8795 family switches have STATIC_MAC_TABLE_USE_FID and
> +	/* KSZ8795/KSZ8895 family switches have STATIC_MAC_TABLE_USE_FID and
>   	 * STATIC_MAC_TABLE_FID definitions off by 1 when doing read on the
>   	 * static MAC table compared to doing write.
>   	 */
> -	if (ksz_is_ksz87xx(dev))
> +	if (!ksz_is_ksz88x3(dev))

I think that for consistency and readability the above should be:

	if (ksz_is_ksz87xx(dev) || ksz_is_8895_family(dev))

Thanks,

Paolo