netdev - Re: [PATCH net V3 1/3] bonding: implement xdo_dev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813071445.3e5f1cc9@kernel.org>
Date: Tue, 13 Aug 2024 07:14:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jianbo Liu <jianbol@...dia.com>
Cc: Tariq Toukan <tariqt@...dia.com>, "liuhangbin@...il.com"
 <liuhangbin@...il.com>, "davem@...emloft.net" <davem@...emloft.net>,
 "andy@...yhouse.net" <andy@...yhouse.net>, Gal Pressman <gal@...dia.com>,
 "jv@...sburgh.net" <jv@...sburgh.net>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "edumazet@...gle.com" <edumazet@...gle.com>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net V3 1/3] bonding: implement xdo_dev_state_free and
 call it after deletion

On Tue, 13 Aug 2024 02:58:12 +0000 Jianbo Liu wrote:
> > > +       rcu_read_lock();
> > > +       bond = netdev_priv(bond_dev);
> > > +       slave = rcu_dereference(bond->curr_active_slave);
> > > +       real_dev = slave ? slave->dev : NULL;
> > > +       rcu_read_unlock();  
> > 
> > What's holding onto real_dev once you drop the rcu lock here?  
> 
> I think it should be xfrm state (and bond device).

Please explain it in the commit message in more certain terms.