netdev - Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb027f6b-83aa-4524-8956-266808a1f919@redhat.com>
Date: Tue, 13 Aug 2024 16:47:34 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
 Madhu Chittim <madhu.chittim@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Simon Horman <horms@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

On 8/13/24 16:12, Jakub Kicinski wrote:
> To me using input / output is more intuitive, as it matches direction
> of traffic flow. I'm fine with root / leaf tho, as I said.

Can we converge on root / leaf ?

>>>> subtree_set() ?
>>>
>>> The operation is grouping inputs and creating a scheduler node.
>>
>> Creating a node inside a tree, isn't it? Therefore subtree.
> 
> All nodes are inside the tree.
> 
>> But it could be unified to node_set() as Paolo suggested. That would
>> work for any node, including leaf, tree, non-existent internal node.
> 
> A "set" operation which creates a node.

Here the outcome is unclear to me. My understanding is that group() does 
not fit Jiri nor Donald and and node_set() or subtree_set() do not fit 
Jakub.

Did I misread something? As a trade-off, what about, group_set()?

Thanks,

Paolo