netdev - Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for allocated ringbufs of link group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrt4LGFh7kMwGczb@shredder.mtl.com>
Date: Tue, 13 Aug 2024 18:13:48 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Wen Gu <guwen@...ux.alibaba.com>, wenjia@...ux.ibm.com,
	jaka@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, alibuda@...ux.alibaba.com,
	tonylu@...ux.alibaba.com, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	danieller@...dia.com
Subject: Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for
 allocated ringbufs of link group

On Tue, Aug 13, 2024 at 07:40:42AM -0700, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 17:55:17 +0800 Wen Gu wrote:
> > On 2024/8/13 08:41, Jakub Kicinski wrote:
> > > On Wed,  7 Aug 2024 15:59:38 +0800 Wen Gu wrote:  
> > >> +	if (nla_put_u64_64bit(skb, SMC_NLA_LGR_R_SNDBUF_ALLOC,
> > >> +			      lgr->alloc_sndbufs, SMC_NLA_LGR_R_PAD))  
> > > 
> > > nla_put_uint()  
> > 
> > Hi, Jakub. Thank you for reminder.
> > 
> > I read the commit log and learned the advantages of this helper.
> > But it seems that the support for corresponding user-space helpers
> > hasn't kept up yet, e.g. can't find a helper like nla_get_uint in
> > latest libnl.
> 
> Add it, then.

Danielle added one to libmnl:

https://git.netfilter.org/libmnl/commit/?id=102942be401a99943b2c68981b238dadfa788f2d

Intention is to use it in ethtool once it appears in a released version
of libmnl.