netdev - Re: [PATCH net-next v2 1/2] bnxt_en: Extend maximum length of version string by 1 byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=TiVoeiG5zmxLCUn6hWf4OCLehybo2YdNKG2uCoYBNHA@mail.gmail.com>
Date: Tue, 13 Aug 2024 10:01:17 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Pavan Chebbi <pavan.chebbi@...adcom.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] bnxt_en: Extend maximum length of version
 string by 1 byte

On Tue, Aug 13, 2024 at 7:33 AM Simon Horman <horms@...nel.org> wrote:
>
> This corrects an out-by-one error in the maximum length of the package
> version string. The size argument of snprintf includes space for the
> trailing '\0' byte, so there is no need to allow extra space for it by
> reducing the value of the size argument by 1.
>
> Found by inspection.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@...nel.org>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)