netdev - Re: [bpf-next 0/3] samples/bpf: Remove obsolete tracing-related tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKGpzgnQ+=W==EQ56CKXYCpDx=kLHMhoo+3KZQy9sOUKNeYtw@mail.gmail.com>
Date: Wed, 14 Aug 2024 02:39:34 +0900
From: "Daniel T. Lee" <danieltimlee@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, 
	Yipeng Zou <zouyipeng@...wei.com>, linux-kselftest@...r.kernel.org, bpf@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [bpf-next 0/3] samples/bpf: Remove obsolete tracing-related tests

On Tue, Aug 13, 2024 at 6:17 AM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Sun, Aug 11, 2024 at 5:45 PM Daniel T. Lee <danieltimlee@...il.com> wrote:
> >
> > The BPF tracing infrastructure has undergone significant evolution,
> > leading to the introduction of more robust and efficient APIs.
> > However, some of the existing tests in the samples/bpf directory have
> > not kept pace with these developments. These outdated tests not only
> > create confusion among users but also increase maintenance overhead.
> >
> > For starter, this patchset focuses on cleaning up outdated 'tracing'
> > related tests within the BPF testing framework. The goal is to
> > modernize and streamline selftests by removing obsolete tests and
> > migrating necessaries to more appropriate locations.
> >
> > Daniel T. Lee (3):
> >   selftests/bpf: migrate tracepoint overhead test to prog_tests
> >   selftests/bpf: add rename tracepoint bench test
> >   samples/bpf: remove obsolete tracing related tests
> >
>
> We already have tracepoint-specific benchmark (see
> benchs/bench_trigger.c), try `./bench trig-tp` (it will pretty recent
> kernel due to reliance on bpf_modify_return_test_tp() kfunc).
>
> So maybe instead of adding code to selftests, let's just remove it
> from both samples/bpf and prog_tests' test_overhead? Either way
> test_overhead isn't very representative anymore, given big chunk of
> its overhead is in write() syscall?
>

Thanks for the insight!
I'll just drop these two and resend them.

> >  samples/bpf/Makefile                          |  12 -
> >  samples/bpf/test_overhead_kprobe.bpf.c        |  41 ----
> >  samples/bpf/test_overhead_raw_tp.bpf.c        |  17 --
> >  samples/bpf/test_overhead_tp.bpf.c            |  23 --
> >  samples/bpf/test_overhead_user.c              | 225 ------------------
> >  samples/bpf/test_override_return.sh           |  16 --
> >  samples/bpf/test_probe_write_user.bpf.c       |  52 ----
> >  samples/bpf/test_probe_write_user_user.c      | 108 ---------
> >  samples/bpf/tracex7.bpf.c                     |  15 --
> >  samples/bpf/tracex7_user.c                    |  56 -----
> >  tools/testing/selftests/bpf/bench.c           |   2 +
> >  .../selftests/bpf/benchs/bench_rename.c       |  16 ++
> >  .../selftests/bpf/benchs/run_bench_rename.sh  |   2 +-
> >  .../selftests/bpf/prog_tests/test_overhead.c  |  14 +-
> >  .../selftests/bpf/progs/test_overhead.c       |  11 +-
> >  15 files changed, 39 insertions(+), 571 deletions(-)
> >  delete mode 100644 samples/bpf/test_overhead_kprobe.bpf.c
> >  delete mode 100644 samples/bpf/test_overhead_raw_tp.bpf.c
> >  delete mode 100644 samples/bpf/test_overhead_tp.bpf.c
> >  delete mode 100644 samples/bpf/test_overhead_user.c
> >  delete mode 100755 samples/bpf/test_override_return.sh
> >  delete mode 100644 samples/bpf/test_probe_write_user.bpf.c
> >  delete mode 100644 samples/bpf/test_probe_write_user_user.c
> >  delete mode 100644 samples/bpf/tracex7.bpf.c
> >  delete mode 100644 samples/bpf/tracex7_user.c
> >
> > --
> > 2.43.0
> >



-- 
Best,
Daniel T. Lee