netdev - RE: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB355819407FDCD6E1E601BB33EC862@BYAPR11MB3558.namprd11.prod.outlook.com>
Date: Tue, 13 Aug 2024 23:09:48 +0000
From: <Tristram.Ha@...rochip.com>
To: <krzk@...nel.org>, <krzk+dt@...nel.org>
CC: <davem@...emloft.net>, <conor+dt@...nel.org>, <edumazet@...gle.com>,
	<robh@...nel.org>, <olteanv@...il.com>, <f.fainelli@...il.com>,
	<andrew@...n.ch>, <devicetree@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <Woojung.Huh@...rochip.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <marex@...x.de>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII
 port support to KSZ9477 switch

> On 10/08/2024 01:38, Tristram.Ha@...rochip.com wrote:
> > From: Tristram Ha <tristram.ha@...rochip.com>
> >
> > The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> > connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
> 
> Binding should say it, not commit msg. But aren't you duplicating
> something like phy-connection-type?

The sgmii-mode parameter is just used internally.  I am not sure using
phy-connection-type or phy-mode is appropriate.

> > @@ -137,6 +144,7 @@ examples:
> >              compatible = "microchip,ksz9477";
> >              reg = <0>;
> >              reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
> > +            sgmii-mode = <1>;
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

Sorry, I missed the example part.