netdev - Re: [selftest] udpgro test report fail but passed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6517ad52-e0c6-4f68-aa7a-8420a84c8c23@redhat.com>
Date: Tue, 13 Aug 2024 10:24:34 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [selftest] udpgro test report fail but passed

On 8/13/24 05:29, Hangbin Liu wrote:
> In our recently internal testing, the udpgro.sh test reports failed but it
> still return 0 as passed. e.g.
> 
> ```
> ipv6
>   no GRO                                  ok
>   no GRO chk cmsg                         ok
>   GRO                                     ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> 
> failed
>   GRO chk cmsg                            ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> 
> failed
>   GRO with custom segment size            ./udpgso_bench_rx: recv: bad packet len, got 500, expected 14520
> 
> failed
>   GRO with custom segment size cmsg       ./udpgso_bench_rx: recv: bad packet len, got 500, expected 14520
> 
> failed
>   bad GRO lookup                          ok
>   multiple GRO socks                      ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> 
> ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> 
> failed
> ```
> 
> For run_one_2sock testing, I saw
> 
> ```
>          ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} -p 12345 &
>          ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 10 ${rx_args} && \
>                  echo "ok" || \
>                  echo "failed" &
>          ...
>          ./udpgso_bench_tx ${tx_args}
>          ret=$?
>          wait $(jobs -p)
>          return $ret
> ```
> 
> So what's the effect if it echo "failed" while ret == 0?

It's just pour integration between the script and the selftests harness.

The script should capture the pid of the background UDP receiver, wait 
poll for a bit for such process termination after that the sender 
completes, then send a termination signal, capture the receiver exit 
code and use it to emit the success/fail message and update the script 
return code.

Could you please have a shot at the above?

BTW I sometimes observed similar failures in the past when the bpf 
program failed to load.

Cheers,

Paolo