netdev - Re: [PATCH iwl-net v2] ice: Add netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc23dde3-8298-4cd6-b2cd-7e9d7bb32d65@linux.intel.com>
Date: Wed, 14 Aug 2024 12:57:40 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 Jakub Kicinski <kuba@...nel.org>, Igor Bagnucki <igor.bagnucki@...el.com>,
 Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH iwl-net v2] ice: Add netif_device_attach/detach into PF
 reset flow

On 13.08.2024 21:24, Maciej Fijalkowski wrote:
> On Tue, Aug 13, 2024 at 05:31:37PM +0200, Dawid Osuchowski wrote:
>> On 13.08.2024 13:49, Maciej Fijalkowski wrote:
>>> What about other intel drivers tho?
>>
>> I have not performed detailed analysis of other intel ethernet drivers in
>> this regard, but it is surely a topic worth investigating.
> 
> If you could take some action upon this then it would be great. I'm always
> hesitating with providing the review tag against a change that already
> contains few of them, but given that I dedicated some time to look into
> that:
> 
I got a valid concern from Kalesh (CCd) on the v1 thread 
(https://lore.kernel.org/netdev/CAH-L+nOFqs-K5YzfrfmpRHbhDGM-+1ahhWh4NXATX1FqZiPVLQ@mail.gmail.com/) 
about the attaching only if link is up.

On 14.08.2024 05:19, Kalesh Anakkur Purayil wrote:
 > [Kalesh] Is there any reason to attach back the netdev only if link is
 > up? IMO, you should attach the device back irrespective of physical
 > link status. In ice_prepare_for_reset(), you are detaching the device
 > unconditionally.
 >
 > I may be missing something here.

I agree with his suggestion to do the netif_device_attach() irrespective 
of link being up. Should I sent a v3 with the change? I have already 
tested that locally and it seems to fix the reported issue with NULL 
pointer dereference as well.

--Dawid

> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> 
>>
>> --Dawid