netdev - Re: [PATCH -next] sfc: Add missing pci_disable_device() for efx_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e52b10f-ad28-7927-fa60-f00755b32756@gmail.com>
Date: Wed, 14 Aug 2024 12:04:15 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Yi Yang <yiyang13@...wei.com>, habetsm.xilinx@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, vladimir.oltean@....com, alex.austin@....com
Cc: netdev@...r.kernel.org, linux-net-drivers@....com
Subject: Re: [PATCH -next] sfc: Add missing pci_disable_device() for
 efx_pm_resume()

On 14/08/2024 10:29, Yi Yang wrote:
> Add missing pci_disable_device() in error path of efx_pm_resume().
> 
> Fixes: 6e173d3b4af9 ("sfc: Copy shared files needed for Siena (part 1)")
> Signed-off-by: Yi Yang <yiyang13@...wei.com>

Hi Yi, a couple of questions.
1) Could you explain in more detail in the commit message why this
 is needed?  It's far from clear to me, though that could just be
 due to my limited knowledge about PM.
2) Is there any reason to only do this for Siena?  AFAICT the ef10/
 ef100 driver has the same code (drivers/net/ethernet/sfc/efx.c),
 so would this change also be needed there?  Same goes for Falcon
 (drivers/net/ethernet/sfc/falcon/efx.c:ef4_pm_resume).

-ed