netdev - Re: [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813171710.599d3f01@kernel.org>
Date: Tue, 13 Aug 2024 17:17:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 intel-wired-lan@...ts.osuosl.org (moderated list:INTEL ETHERNET DRIVERS),
 Jeroen de Borst <jeroendb@...gle.com>, Jiri Pirko <jiri@...nulli.us>, Leon
 Romanovsky <leon@...nel.org>, linux-kernel@...r.kernel.org (open list),
 linux-rdma@...r.kernel.org (open list:MELLANOX MLX4 core VPI driver),
 Lorenzo Bianconi <lorenzo@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Saeed Mahameed <saeedm@...dia.com>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Shailend Chand
 <shailend@...gle.com>, Tariq Toukan <tariqt@...dia.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Willem de Bruijn <willemb@...gle.com>, Yishai
 Hadas <yishaih@...dia.com>, Ziwei Xiao <ziweixiao@...gle.com>
Subject: Re: [RFC net-next 0/6] Cleanup IRQ affinity checks in several
 drivers

On Mon, 12 Aug 2024 14:56:21 +0000 Joe Damato wrote:
> Several drivers make a check in their napi poll functions to determine
> if the CPU affinity of the IRQ has changed. If it has, the napi poll
> function returns a value less than the budget to force polling mode to
> be disabled, so that it can be rescheduled on the correct CPU next time
> the softirq is raised.

Any reason not to use the irq number already stored in napi_struct ?