netdev - Re: [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240814135015.GB322002@kernel.org>
Date: Wed, 14 Aug 2024 14:50:15 +0100
From: Simon Horman <horms@...nel.org>
To: Daiwei Li <daiweili@...gle.com>
Cc: intel-wired-lan@...ts.osuosl.org, vinicius.gomes@...el.com,
	anthony.l.nguyen@...el.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, kurt@...utronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	pabeni@...hat.com, przemyslaw.kitszel@...el.com,
	richardcochran@...il.com, sasha.neftin@...el.com
Subject: Re: [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for
 82580

On Tue, Aug 13, 2024 at 09:55:53PM -0700, Daiwei Li wrote:
> 82580 NICs have a hardware bug that makes it
> necessary to write into the TSICR (TimeSync Interrupt Cause) register
> to clear it:
> https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/
> 
> Add a conditional so only for 82580 we write into the TSICR register,
> so we don't risk losing events for other models.
> 
> Without this change, when running ptp4l with an Intel 82580 card,
> I get the following output:
> 
> > timed out while polling for tx timestamp increasing tx_timestamp_timeout or
> > increasing kworker priority may correct this issue, but a driver bug likely
> > causes it
> 
> This goes away with this change.
> 
> This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync events").
> 
> Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
> Closes: https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com/
> Tested-by: Daiwei Li <daiweili@...gle.com>
> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Signed-off-by: Daiwei Li <daiweili@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>