netdev - Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86d049ce-226f-4b3d-a8f6-82374f0a0b71@amd.com>
Date: Wed, 14 Aug 2024 11:01:02 -0700
From: Brett Creeley <bcreeley@....com>
To: Joe Damato <jdamato@...tly.com>, Brett Creeley <brett.creeley@....com>,
 netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
 edumazet@...gle.com, pabeni@...hat.com, shannon.nelson@....com
Subject: Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0


On 8/14/2024 4:33 AM, Joe Damato wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Tue, Aug 13, 2024 at 04:41:21PM -0700, Brett Creeley wrote:
>> The change in the fixes allowed the ionic_tx_cq_service() function
>> to be called when budget == 0, but no packet completions will
>> actually be serviced since it returns immediately when budget is
>> passed in as 0. Fix this by not checking budget before entering
>> the completion servicing while loop. This will allow a single
>> cq entry to be processed since ++work_done will always be greater
>> than work_to_do.
>>
>> With this change a simple netconsole test as described in
>> Documentation/networking/netconsole.txt works as expected.
>>
>> Fixes: 2f74258d997c ("ionic: minimal work with 0 budget")
>> Signed-off-by: Brett Creeley <brett.creeley@....com>
>> ---
>>   drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 3 ---
>>   1 file changed, 3 deletions(-)
> 
> I think fixes may need to CC stable, but in either case:
> 
> Reviewed-by: Joe Damato <jdamato@...tly.com>

Thanks for the reminder and review. I will CC stable if I end up needing 
to re-push a v2.

Brett