netdev - Re: Question about TPA/HDS feature of bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTWnDk4eQLgzNXJ-LtudXugEwrLSFB+T-EByaFAcudOk2A@mail.gmail.com>
Date: Thu, 15 Aug 2024 18:06:52 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: Jakub Kicinski <kuba@...nel.org>, David Wei <dw@...idwei.uk>, 
	Somnath Kotur <somnath.kotur@...adcom.com>, Mina Almasry <almasrymina@...gle.com>, 
	Netdev <netdev@...r.kernel.org>
Subject: Re: Question about TPA/HDS feature of bnxt_en

On Thu, Aug 15, 2024 at 2:18 AM Michael Chan <michael.chan@...adcom.com> wrote:
>

Hi Michael

> On Wed, Aug 14, 2024 at 12:51 AM Taehee Yoo <ap420073@...il.com> wrote:
> >
> > On Wed, Aug 14, 2024 at 11:08 AM Michael Chan <michael.chan@...adcom.com> wrote:
> > > Yes, the rx_copy_thresh is also the HDS threshold. The default value
> > > is 256, meaning that packet sizes below 256 will not be split. So a
> > > 300-byte packet should be split.
> > >
> > > TPA is related but is separate. There is a min_agg_len that is
> > > currently set to 512 in bnxt_hwrm_vnic_set_tpa(). I think it should
> > > be fine to reduce this value for TPA to work on smaller packets.
> >
> > Thank you so much for confirming the hds_threshold variable.
> > I tested this variable, it worked as I expected.
> > For testing, I kept the rx_copy_threshold and tpa settings unchanged,
> > but modified the hds_threshold variable to 0.
> >
> > BTW, how about separating rx_copy_threshold into rx-copy-break
> > and hds_threshold?
> > If so, we can implement `ethtool --set-tunable eth0 rx-copybreak N`
> > and `ethtool -G eth0 tcp-data-split on`
> >
> Yes, we can do that. I have the rx-copybreak tunable implemented in
> the OOT driver already and can be sent upstream. tcp_data_split can
> also be added. Thanks.

Thanks a lot for sharing that!
Taehee Yoo