netdev - Re: [PATCH net v6 0/2] Enhance network interface feature testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240815110442.1389625-1-jain.abhinav177@gmail.com>
Date: Thu, 15 Aug 2024 16:34:42 +0530
From: Abhinav Jain <jain.abhinav177@...il.com>
To: kuba@...nel.org
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	jain.abhinav177@...il.com,
	javier.carrasco.cruz@...il.com,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	shuah@...nel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH net v6 0/2] Enhance network interface feature testing

On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote:

> On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> > > Changes in v6:
> > > Use XFAIL for ethtool operations that are unsupported instead of SKIP.  
> >
> > One more:
> >
> > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address"
> >
> > I think the SKIP -> XFAIL conversion should be a separate patch (for
> > total of 3 patches in the series).
>
> P.S. and please change the subject to [PATCH net-next], it's a net-next
> change, not a net fix.

I have sent v7 now with net-next instead of net:
https://lore.kernel.org/all/20240815105924.1389290-1-jain.abhinav177@gmail.com

For set IP address part, I have added logic to XFAIL if veth pair was created 
and to SKIP if that's not the case in third patch of the series as directed above.

Right now, there is no logic to set IP address in the script for normal interfaces
either and it is a TODO as well. I will focus on it next after this one is applied.

Thank you for all the help Jakub.