netdev - Re: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0520caa-7c73-4a96-a21e-f0bbac95b5d3@linux.dev>
Date: Thu, 15 Aug 2024 11:15:32 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Simon Horman <horms@...nel.org>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Michal Simek <michal.simek@....com>,
 Daniel Borkmann <daniel@...earbox.net>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 linux-arm-kernel@...ts.infradead.org, Jakub Kicinski <kuba@...nel.org>,
 Ariane Keller <ariane.keller@....ee.ethz.ch>
Subject: Re: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go
 into promiscuous mode

On 8/15/24 10:59, Simon Horman wrote:
> On Mon, Aug 12, 2024 at 04:04:36PM -0400, Sean Anderson wrote:
>> A message about being in promiscuous mode is printed every time each
>> additional multicast address beyond four is added. Suppress this message
>> like is done in other drivers. And don't set IFF_PROMISC in ndev->flags;
>> contrary to the comment we don't have to inform the net subsystem.
> 
> Hi Sean,
> 
> FWIIW, this feels like two things that could be two patches.
> 
> ...

OK