netdev - Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2005b62-82d6-47b0-bd09-b9ee0c16070a@amd.com>
Date: Wed, 14 Aug 2024 17:59:54 -0700
From: Brett Creeley <bcreeley@....com>
To: Jakub Kicinski <kuba@...nel.org>, Brett Creeley <brett.creeley@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, shannon.nelson@....com
Subject: Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0



On 8/14/2024 5:27 PM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Tue, 13 Aug 2024 16:41:21 -0700 Brett Creeley wrote:
>> The change in the fixes allowed the ionic_tx_cq_service() function
>> to be called when budget == 0, but no packet completions will
>> actually be serviced since it returns immediately when budget is
>> passed in as 0. Fix this by not checking budget before entering
>> the completion servicing while loop. This will allow a single
>> cq entry to be processed since ++work_done will always be greater
>> than work_to_do.
>>
>> With this change a simple netconsole test as described in
>> Documentation/networking/netconsole.txt works as expected.
> 
> I think I see a call to XDP cleanup as part of Tx processing.
> XDP can't be handled with budget of 0 :(

Well that's unfortunate to say the least. I will look at how to fix this 
as well and send a v2.

Thanks,

Brett
> --
> pw-bot: cr