netdev - Re: [PATCH] devlink: Extend the devlink rate API to support rate management on traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408150939.GeZ6uR8S-lkp@intel.com>
Date: Thu, 15 Aug 2024 10:02:32 +0800
From: kernel test robot <lkp@...el.com>
To: Cosmin Ratiu <cratiu@...dia.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, cjubran@...dia.com, cratiu@...dia.com,
	tariqt@...dia.com, saeedm@...dia.com, yossiku@...dia.com,
	gal@...dia.com, jiri@...dia.com
Subject: Re: [PATCH] devlink: Extend the devlink rate API to support rate
 management on traffic classes

Hi Cosmin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.11-rc3 next-20240814]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cosmin-Ratiu/devlink-Extend-the-devlink-rate-API-to-support-rate-management-on-traffic-classes/20240814-232253
base:   linus/master
patch link:    https://lore.kernel.org/r/20240814085320.134075-2-cratiu%40nvidia.com
patch subject: [PATCH] devlink: Extend the devlink rate API to support rate management on traffic classes
config: arc-randconfig-001-20240815 (https://download.01.org/0day-ci/archive/20240815/202408150939.GeZ6uR8S-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408150939.GeZ6uR8S-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408150939.GeZ6uR8S-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/devlink/rate.c:755: warning: Function parameter or struct member 'devlink_port' not described in 'devl_rate_traffic_class_create'
>> net/devlink/rate.c:755: warning: Function parameter or struct member 'parent' not described in 'devl_rate_traffic_class_create'
>> net/devlink/rate.c:755: warning: Excess function parameter 'devlink' description in 'devl_rate_traffic_class_create'


vim +755 net/devlink/rate.c

   744	
   745	/**
   746	 * devl_rate_traffic_class_create - create devlink rate queue
   747	 * @devlink: devlink instance
   748	 * @priv: driver private data
   749	 * @tc_id: identifier of the new traffic class
   750	 *
   751	 * Create devlink rate object of type node
   752	 */
   753	int devl_rate_traffic_class_create(struct devlink_port *devlink_port, void *priv, u16 tc_id,
   754					   struct devlink_rate *parent)
 > 755	{
   756		struct devlink *devlink = devlink_port->devlink;
   757		struct devlink_rate *devlink_rate;
   758	
   759		devl_assert_locked(devlink);
   760	
   761		devlink_rate = devlink_rate_traffic_class_get_by_id(devlink, tc_id);
   762		if (!IS_ERR(devlink_rate))
   763			return -EEXIST;
   764	
   765		devlink_rate = kzalloc(sizeof(*devlink_rate), GFP_KERNEL);
   766		if (!devlink_rate)
   767			return -ENOMEM;
   768	
   769		if (parent) {
   770			devlink_rate->parent = parent;
   771			refcount_inc(&devlink_rate->parent->refcnt);
   772		}
   773	
   774		devlink_rate->type = DEVLINK_RATE_TYPE_TRAFFIC_CLASS;
   775		devlink_rate->devlink = devlink;
   776		devlink_rate->devlink_port = devlink_port;
   777		devlink_rate->tc_id = tc_id;
   778		devlink_rate->priv = priv;
   779		list_add_tail(&devlink_rate->list, &devlink->rate_list);
   780		devlink_port->devlink_rate = devlink_rate;
   781		devlink_rate_notify(devlink_rate, DEVLINK_CMD_RATE_NEW);
   782	
   783		return 0;
   784	}
   785	EXPORT_SYMBOL_GPL(devl_rate_traffic_class_create);
   786	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki